Skip to content

Conversation

xiangchenjhu
Copy link
Collaborator

Add new columns: xtb_walltime to record the runtime of the xTB module, dft_walltime to capture the DFT module's runtime, and xyz_len to measure the length of the xyz structure.

@xiangchenjhu xiangchenjhu marked this pull request as ready for review October 4, 2024 20:17
@xiangchenjhu xiangchenjhu requested a review from a team as a code owner October 4, 2024 20:17
Copy link
Member

@amitschang amitschang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

xyz_block = MolToXYZBlock(mol)
ste_score = calculate_ste(mol)
row["xyz"] = xyz_block
row["xyz_len"] = len(xyz_block)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 😄

@xiangchenjhu
Copy link
Collaborator Author

Thanks for the input!

@xiangchenjhu xiangchenjhu merged commit 6a303e0 into main Oct 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants