generated from ssec-jhu/base-template
-
Notifications
You must be signed in to change notification settings - Fork 1
add contributing helper doc #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
|
||
# Contributing to the BluePhos Pipeline Project | ||
|
||
Thank you for your interest in contributing to the BluePhos pipeline project! As a contributor, you’ll work from your fork of the main repository. This document outlines the steps to set up your development environment, guidelines for coding, and instructions for submitting contributions. | ||
|
||
## Repository Information | ||
|
||
- **Main Repository**: [BluePhos Main Repo](https://github.com/ssec-jhu/bluephos.git) | ||
|
||
## Getting Started | ||
|
||
1. **Fork the Repository**: First, create a fork of the main repository in your own GitHub account. This will allow you to freely make changes without affecting the main repository. | ||
|
||
2. **Clone Your Fork**: Clone your fork to your local machine: | ||
```bash | ||
git clone https://github.com/your-username/bluephos.git | ||
cd bluephos | ||
``` | ||
|
||
3. **Add the Main Repository as Upstream**: To keep your fork in sync with the latest updates from the main repo, add it as a second remote named `upstream`: | ||
```bash | ||
git remote add upstream https://github.com/ssec-jhu/bluephos.git | ||
``` | ||
|
||
4. **Create a Branch**: Create a new branch for each feature or bug fix: | ||
```bash | ||
git checkout -b feature/your-feature-name | ||
``` | ||
|
||
## Making Changes | ||
|
||
- **Coding Standards**: Follow PEP 8 for Python code. Use `ruff format` or `tox -e format` to ensure code formatting aligns with the repository’s requirements. | ||
- **Testing**: Ensure your changes pass all tests. Include relevant tests for any new features you add. | ||
- **Documentation**: Update the documentation for any significant code changes. This includes comments, docstrings, and relevant updates to the `README.md`. | ||
|
||
## Keeping Your Fork Updated | ||
|
||
Regularly pull updates from the main repository to keep your fork in sync: | ||
```bash | ||
git fetch upstream | ||
git merge upstream/main | ||
``` | ||
|
||
## Submitting a Pull Request | ||
|
||
When you’re ready to contribute your changes: | ||
|
||
1. **Commit Your Changes**: Write concise and descriptive commit messages. | ||
```bash | ||
git add . | ||
git commit -m "Description of changes" | ||
``` | ||
|
||
2. **Push to Your Fork**: | ||
```bash | ||
git push origin feature/your-feature-name | ||
``` | ||
|
||
3. **Open a Pull Request**: | ||
- Go to your forked repository on GitHub. | ||
- Click on **New Pull Request**. | ||
- Ensure the base repository is `ssec-jhu/bluephos` and the base branch is `main`. | ||
- Provide a title and description for your pull request. | ||
- Submit the pull request for review. | ||
|
||
## Code Review Process | ||
|
||
Once you submit a pull request: | ||
- The maintainers will review your changes and may request modifications. | ||
- Please address any feedback and re-submit for review. | ||
|
||
## Issues and Support | ||
|
||
If you encounter issues or have questions, feel free to open an issue on GitHub. We’ll do our best to assist. | ||
|
||
## License | ||
|
||
By contributing, you agree that your contributions will be licensed under the same open-source license as the project. | ||
|
||
--- | ||
|
||
Thank you for your contributions to the BluePhos pipeline! We’re excited to work with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I think it would be better to just use the
tox
command. Fewer options is better and tox codifies more than just the formatting - we can change in it's code without changing advice here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Using tox -e format as the single command has clear advantages. I initially used ruff format . because it was mentioned in the CI error, but after running tox -e format, it made additional adjustments on 9 more files :).