Iainland/cors #315
Open
Iainland/cors #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
amitschang
reviewed
Jun 6, 2025
|
|
||
| app.add_middleware( | ||
| CORSMiddleware, | ||
| allow_origin_regex=r"https?://(localhost|127\.0\.0\.1)(:\d+)?", |
There was a problem hiding this comment.
Should we keep this in the AppSettings? In the settings we could also store the list of allowed origins (defaulting to [] and used here for allowed_origins), so then the change here would be complete and no need to update later.
There was a problem hiding this comment.
yeah good idea. appsettings makes sense for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (ssec-jhu/evolver-ui#61) means all Evolver HTTP requests originate from the browser. This means the evolver-ng service must include a CORS header allowing requests for a locally running ui instance. Later we can add the domain where the ui is hosted.