Skip to content

Commit d589af7

Browse files
committed
remove todos
1 parent 73366a2 commit d589af7

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

app/routes/devices.$id.hardware.$hardware_name.history.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ export async function loader({ params, request }: LoaderFunctionArgs) {
4545

4646
const properties = searchParams.get("properties")?.split(",");
4747

48-
// TODO History api is in flux.
4948
const {
5049
data: { data },
5150
} = await Evolver.history({

app/routes/devices.$id.hardware.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export const handle = {
2525
export default function Hardware() {
2626
const { id, hardware_name } = useParams();
2727
const [queryParams] = useSearchParams();
28-
// TODO: figure this out, should submit to nearest layout route with a loader
2928
const loaderData = useRouteLoaderData<typeof loader>("routes/devices.$id");
3029
let evolverConfig = {} as EvolverConfigWithoutDefaults;
3130

app/utils/pingDevice.server.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,16 @@ export async function pingDevice(
2828
const evolverDescription = await Evolver.describe({
2929
client: evolverClient,
3030
});
31-
// TODO: Confirm this is all accessible
3231
const {
3332
config: { name },
34-
id,
3533
} = evolverDescription.data;
36-
37-
return { online: true, name, id };
34+
return { online: true, name };
3835
} catch (error) {
3936
if (error instanceof DOMException && error.name === "AbortError") {
4037
console.info(
4138
`request to device ${evolver_url_addr} timed out after ${timeout}ms, now designated offline`,
4239
);
4340
}
44-
return { online: false, name: "unknown", id: "unknown" };
41+
return { online: false, name: "unknown" };
4542
}
4643
}

0 commit comments

Comments
 (0)