Skip to content

Pass std::string and RankInfo by value and use std::move() to move it, reducing allocations and copies#1527

Closed
leekillough wants to merge 1 commit into
sstsimulator:develfrom
leekillough:modernize-pass-by-value
Closed

Pass std::string and RankInfo by value and use std::move() to move it, reducing allocations and copies#1527
leekillough wants to merge 1 commit into
sstsimulator:develfrom
leekillough:modernize-pass-by-value

Conversation

@leekillough
Copy link
Copy Markdown
Contributor

@leekillough leekillough commented Dec 31, 2025 •
edited
Loading

This is less important than #1518, and should only be merged after it.

This was obtained by running scripts/clang-tidy.sh --checks modernize-pass-by-value --fix.

@github-actions github-actions Bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Dec 31, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 31, 2025

CLANG-FORMAT TEST - PASSED

@sst-autotester
Copy link
Copy Markdown
Contributor

sst-autotester commented Dec 31, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@leekillough leekillough force-pushed the modernize-pass-by-value branch from d832de9 to e1759b5 Compare January 20, 2026 15:03
@github-actions github-actions Bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Jan 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026

CLANG-FORMAT TEST - PASSED

@sst-autotester
Copy link
Copy Markdown
Contributor

sst-autotester commented Jan 20, 2026

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@leekillough leekillough force-pushed the modernize-pass-by-value branch from e1759b5 to 7f7262a Compare January 23, 2026 17:02
@github-actions github-actions Bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Jan 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 23, 2026

CLANG-FORMAT TEST - PASSED

@sst-autotester
Copy link
Copy Markdown
Contributor

sst-autotester commented Jan 23, 2026

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@feldergast
Copy link
Copy Markdown
Contributor

feldergast commented Apr 15, 2026

Closing. None of these are in performance critical paths.

@feldergast feldergast closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

AT: CLANG-FORMAT PASS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leekillough @sst-autotester @feldergast