From 6416234868b820613100f6ff2d36833383b09c1a Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Tue, 31 May 2022 17:41:17 +0200 Subject: [PATCH 1/2] cover unknown constants in tests --- tests/rules/data/query-plan-analyzer.php | 7 ++++++- tests/rules/data/syntax-error-in-prepared-statement.php | 5 +++++ tests/rules/data/syntax-error-in-query-method.php | 5 +++++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/tests/rules/data/query-plan-analyzer.php b/tests/rules/data/query-plan-analyzer.php index 00ec3ce7e..62472d1cd 100644 --- a/tests/rules/data/query-plan-analyzer.php +++ b/tests/rules/data/query-plan-analyzer.php @@ -58,6 +58,11 @@ public function unknownQuery(Connection $conn, string $query): void public function nonSimulatableQuery(Connection $conn, $email): void { - $conn->executeQuery('SELECT * FROM ada WHERE email = '.$email); + $conn->executeQuery('SELECT * FROM ada WHERE email = ' . $email); + } + + public function unknownConstant(Connection $conn, int $adaidl): void + { + $conn->executeQuery('SELECT * FROM ada WHERE adaid = ?', [CONSTANT_DOES_NOT_EXIST]); } } diff --git a/tests/rules/data/syntax-error-in-prepared-statement.php b/tests/rules/data/syntax-error-in-prepared-statement.php index ca7f3dbc3..7af4cb25f 100644 --- a/tests/rules/data/syntax-error-in-prepared-statement.php +++ b/tests/rules/data/syntax-error-in-prepared-statement.php @@ -323,4 +323,9 @@ public function preparedNamedParamsSubstitution(Connection $connection) { $connection->preparedQuery('SELECT email FROM ada WHERE email = :param OR email = :parameter', ['param' => 'abc', 'parameter' => 'def']); } + + public function unknownConstant(Connection $connection) + { + $connection->preparedQuery('SELECT email FROM ada WHERE email = :param OR email = :parameter', ['param' => CONSTANT_DOES_NOT_EXIST, 'parameter' => 'def']); + } } diff --git a/tests/rules/data/syntax-error-in-query-method.php b/tests/rules/data/syntax-error-in-query-method.php index e85dc8354..726d94d46 100644 --- a/tests/rules/data/syntax-error-in-query-method.php +++ b/tests/rules/data/syntax-error-in-query-method.php @@ -117,4 +117,9 @@ public function conditionalSyntaxErrorInQueryUnion(PDO $pdo) $pdo->query('SELECT email, adaid FROM ada '.$add.' LIMIT 1', PDO::FETCH_ASSOC); } + + public function unknownConstant(PDO $pdo) + { + $pdo->query('SELECT * FROM ada WHERE doesNotExist='.CONSTANT_DOES_NOT_EXIST, PDO::FETCH_ASSOC); + } } From 1f79b4bebcbc245b3cceaa03eabe9a9b9a60d875 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Tue, 31 May 2022 17:42:17 +0200 Subject: [PATCH 2/2] Update tests/rules/data/query-plan-analyzer.php --- tests/rules/data/query-plan-analyzer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/rules/data/query-plan-analyzer.php b/tests/rules/data/query-plan-analyzer.php index 62472d1cd..4d8cf3989 100644 --- a/tests/rules/data/query-plan-analyzer.php +++ b/tests/rules/data/query-plan-analyzer.php @@ -61,7 +61,7 @@ public function nonSimulatableQuery(Connection $conn, $email): void $conn->executeQuery('SELECT * FROM ada WHERE email = ' . $email); } - public function unknownConstant(Connection $conn, int $adaidl): void + public function unknownConstant(Connection $conn): void { $conn->executeQuery('SELECT * FROM ada WHERE adaid = ?', [CONSTANT_DOES_NOT_EXIST]); }