Using Iterable with @retry leads to silent data corruption

[Zaczero]

@retry is fundamentally incompatible with the Iterable concept.

For example here:

pgstac/src/pypgstac/src/pypgstac/load.py

Line 275 in 13b7d8d

items: Iterable[Dict[str, Any]],

load_partition accepts input from itertools.groupby:

pgstac/src/pypgstac/src/pypgstac/load.py

Lines 617 to 618 in 13b7d8d

	for k, g in itertools.groupby(chunk, lambda x: x["partition"]):
	self.load_partition(self._partition_cache[k], g, insert_mode)

That is Iterable and after first retry will contain empty data, discarding all input.

More about groupby in the Python documentation:

https://docs.python.org/3/library/itertools.html#itertools.groupby

[Zaczero]

I suggest replacing such cases with Collection