Skip to content

add ENABLE_RESPONSE_COMPRESSION option #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add ENABLE_RESPONSE_COMPRESSION option #919

wants to merge 4 commits into from

Conversation

tylanderson
Copy link
Collaborator

@tylanderson tylanderson commented Jun 6, 2025 •
edited
Loading

Related Issue(s):

Proposed Changes:

  1. Adds compression to responses by default
  2. Adds ENABLE_RESPONSE_COMPRESSION env variable which can be set to false to turn off compression (e.g. if a post-hook is enabled)

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@tylanderson tylanderson marked this pull request as ready for review June 9, 2025 22:21
ircwaves
ircwaves requested changes Jun 10, 2025
View reviewed changes
Copy link
Member

@ircwaves ircwaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more bit of doc, but looks good to me. I think we should hear from @philvarner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ircwaves ircwaves ircwaves requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylanderson @ircwaves