remove actualFile and goldenFile fields from Golden data type so cli can apply changes
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes parsing filepaths easier
these filepaths will be decided internally. This will make it easier for the cli to know which files need to be updated. since the cli doesn't get the `Golden` configuration
assign default output directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the title sounds a bit confusing. This addresses issue #60.
To re-iterate the issue. The test is configurable with the
Goldendata type. Users can setactualFileandgoldenFileas file location output. The problem shows with the cli because it doesn't have access toGoldenand makes its own assumptions of the file locations. So when there are changes andhgold -u <golden directory location>is ran it will run but won't update the right files.One of the solutions, which I think is the path of least resistance is to remove
actualFileandgoldenFilefields. Then the test application will just decide on the file locations. This opinionated configuration will enable the cli to assert where the files are located.