-
Notifications
You must be signed in to change notification settings - Fork 37
Refactor toplevel site.yml and fatimage.yml playbooks #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Build for the above image bump: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14660430262/job/41143461025 |
|
Interactive testing @ 3120e49: ✔️ ondemand shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few suggestions for keeping the pattern of how appliances_mode is used consistent. As you said it may also worth documenting how appliances_mode is intended to be used vs builder groups
This reverts commit aa11f43.
…site.yml, by default
|
Testing image build - should rebuild once fix/zenith merged to main anyway: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14778751137 |
ae5ae10 to
c7bd114
Compare
Refactoring to resolve a number of problems and inconsistencies between the
site.ymlandfatimage.ymlplaybooks. The major ones are:iam.ymlandslurm.ymlplaybooks are now run directly fromfatimage.ymlto make making changes to these less error-prone.compute-initexport task moved to a newfinal.ymlplaybook so it will run after any role which generates configuration which it might require.install.ymltask for this role also been moved here for consistency - note this changes commands used for development.gatewayrole which installs ansible-init playbook moved adjacent to ansible-init installsite.ymlandfatimage.ymlis now consistent in that repos are disabled after any post-hook in both cases.site.yml.compute_init,gateway) in groups hierarchy.See https://wiki.stackhpc.com/doc/slurm-top-level-playbooks-HW9BlHDMpm for more detail
TODO: