Skip to content

Conversation

@bertiethorpe
Copy link
Member

No description provided.

@bertiethorpe

This comment was marked as outdated.

@bertiethorpe bertiethorpe marked this pull request as ready for review October 24, 2025 10:14
@bertiethorpe bertiethorpe requested a review from a team as a code owner October 24, 2025 10:14
@bertiethorpe
Copy link
Member Author

Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cernvm repos used for EESSI were added to Ark in stackhpc/stackhpc-release-train#427 (rather than stackhpc/stackhpc-release-train#435 which is what the rest of this is handling). But I think they are currently unused.

If otherwise this is basically good-to-go I'm not averse to punting that fix into a separate PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing cernvm, see PLATFORM-941.

@@ -1,12 +1,5 @@
---
# Should be run on compute nodes you want to run the graphical desktop on
- name: Enable TurboVNC repo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just add a comment to say repofile provided by dnf_repos?

Similarly if its OK to remove this task, I think we can remove the "install epel" task right? dnf_repos will always /will always have to provide it

ood_auth_openidc: "{{ openondemand_auth_defaults.oidc.ood_auth_openidc if (openondemand_auth | lower) == 'oidc' else none }}"
httpd_auth: "{{ openondemand_auth_defaults[openondemand_auth | lower].httpd_auth }}"

# Use Ark pulp repos by default
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Use Ark pulp repos by default
# Use repo file provided by dnf_repos by default

b/c it could be local Pulp, not Ark directly

httpd_auth: "{{ openondemand_auth_defaults[openondemand_auth | lower].httpd_auth }}"

# Use Ark pulp repos by default
ood_use_existing_repo_file: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is wrong here, so its part of the ssl: var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants