-
Notifications
You must be signed in to change notification settings - Fork 37
Use Ark repofiles for additional repos #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cernvm repos used for EESSI were added to Ark in stackhpc/stackhpc-release-train#427 (rather than stackhpc/stackhpc-release-train#435 which is what the rest of this is handling). But I think they are currently unused.
If otherwise this is basically good-to-go I'm not averse to punting that fix into a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing cernvm, see PLATFORM-941.
| @@ -1,12 +1,5 @@ | |||
| --- | |||
| # Should be run on compute nodes you want to run the graphical desktop on | |||
| - name: Enable TurboVNC repo | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just add a comment to say repofile provided by dnf_repos?
Similarly if its OK to remove this task, I think we can remove the "install epel" task right? dnf_repos will always /will always have to provide it
| ood_auth_openidc: "{{ openondemand_auth_defaults.oidc.ood_auth_openidc if (openondemand_auth | lower) == 'oidc' else none }}" | ||
| httpd_auth: "{{ openondemand_auth_defaults[openondemand_auth | lower].httpd_auth }}" | ||
|
|
||
| # Use Ark pulp repos by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Use Ark pulp repos by default | |
| # Use repo file provided by dnf_repos by default |
b/c it could be local Pulp, not Ark directly
| httpd_auth: "{{ openondemand_auth_defaults[openondemand_auth | lower].httpd_auth }}" | ||
|
|
||
| # Use Ark pulp repos by default | ||
| ood_use_existing_repo_file: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is wrong here, so its part of the ssl: var.
No description provided.