Skip to content

Add alert when fluentd queue buffers grow too large #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

priteau
Copy link
Member

@priteau priteau commented Apr 23, 2024

No description provided.

@priteau priteau self-assigned this Apr 23, 2024
@priteau priteau requested a review from a team as a code owner April 23, 2024 20:56
@technowhizz
Copy link
Contributor

technowhizz commented Apr 24, 2024

Should we not warn at 100MiB as that is what the default Opensearch http.max_content_length is set as? Perhaps even warn at 99MiB

@priteau
Copy link
Member Author

priteau commented Apr 24, 2024

Should we not warn at 100MiB as that is what the default Opensearch http.max_content_length is set as? Perhaps even warn at 99MiB

I am open to suggestions, I just picked a random number.

Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pierre.

I think Dawud has a point that until we fix https://stackhpc.atlassian.net/browse/INFRA-666, a lower threshold would be useful, but we should make https://stackhpc.atlassian.net/browse/INFRA-666 a priority.

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is better than nothing. Since the INFRA-666 task is still on the backlog, I propose we move forward with this and we can update it with something more fancy down the line.
Though, we should probably rebase this change onto antelope

@priteau priteau requested review from Alex-Welsh and dougszumski July 8, 2024 13:15
jovial
jovial previously approved these changes Jul 8, 2024
seunghun1ee
seunghun1ee previously approved these changes Jul 8, 2024
@priteau priteau dismissed stale reviews from seunghun1ee and jovial via 329a943 July 8, 2024 13:24
@priteau priteau changed the base branch from stackhpc/yoga to stackhpc/2023.1 July 8, 2024 13:24
@priteau priteau requested review from seunghun1ee and jovial July 8, 2024 13:24
@jovial
Copy link
Contributor

jovial commented Jul 8, 2024

Should we not warn at 100MiB as that is what the default Opensearch http.max_content_length is set as? Perhaps even warn at 99MiB

100 MiB seems like a sane default (99MiB could still technically be posted)

@priteau priteau merged commit dc6e023 into stackhpc/2023.1 Jul 8, 2024
12 checks passed
@priteau priteau deleted the fluentd-alerts branch July 8, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants