Skip to content

Ironic overcloud hypervisor deployment #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: stackhpc/2024.1
Choose a base branch
from

Conversation

assumptionsandg
Copy link
Contributor

@assumptionsandg assumptionsandg commented Jun 6, 2024

Deployment playbook for baremetal instances to be used as hypervisors.

TODO: Documentation refactoring (separate everything prior to hypervisors?)

@assumptionsandg assumptionsandg changed the title Ironic overcloud hypervisor deployment WIP: Ironic overcloud hypervisor deployment Jun 6, 2024
@assumptionsandg assumptionsandg self-assigned this Jun 6, 2024
@assumptionsandg assumptionsandg force-pushed the baremetal-hypervisor branch 2 times, most recently from d02d07d to 7598716 Compare June 19, 2024 11:14
@assumptionsandg assumptionsandg force-pushed the baremetal-hypervisor branch 2 times, most recently from ed6155e to e850079 Compare June 19, 2024 11:40
@Alex-Welsh
Copy link
Member

@assumptionsandg remember to mark conversations as resolved when you've completed them! Makes it much easier for reviewers to know when to re-review.

Is this still a draft? Who do you need a review from to get it merged?

@assumptionsandg
Copy link
Contributor Author

@assumptionsandg remember to mark conversations as resolved when you've completed them! Makes it much easier for reviewers to know when to re-review.

Is this still a draft? Who do you need a review from to get it merged?

It's still WIP on the client side of things, hence leaving it as a draft here. We could merge what's here now and interate/fix things as the client work progresses if what's here will be useful to people.

@Alex-Welsh
Copy link
Member

Alex-Welsh commented Sep 9, 2024

@assumptionsandg remember to mark conversations as resolved when you've completed them! Makes it much easier for reviewers to know when to re-review.
Is this still a draft? Who do you need a review from to get it merged?

It's still WIP on the client side of things, hence leaving it as a draft here. We could merge what's here now and interate/fix things as the client work progresses if what's here will be useful to people.

I'd be happy with it as long as you add a big warning at the top saying the docs are still WIP. Something is better than nothing

@assumptionsandg assumptionsandg changed the title WIP: Ironic overcloud hypervisor deployment Ironic overcloud hypervisor deployment Sep 9, 2024
@assumptionsandg assumptionsandg marked this pull request as ready for review September 9, 2024 10:57
@assumptionsandg assumptionsandg requested a review from a team as a code owner September 9, 2024 10:57
@Alex-Welsh
Copy link
Member

@assumptionsandg you need to tag people for re-review when you make changes. This has been sat around for two months and I don't think anyone has looked at it

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good docs. I've got a lot of comments but they're mostly just small formatting and grammar fixes.

Co-authored-by: Alex-Welsh <112560678+Alex-Welsh@users.noreply.github.com>
@Alex-Welsh Alex-Welsh added documentation Improvements or additions to documentation antelope Targets the Antelope OpenStack release labels Nov 15, 2024
@Alex-Welsh
Copy link
Member

@assumptionsandg let me know when this is ready for a re-review

@assumptionsandg assumptionsandg changed the base branch from stackhpc/2023.1 to stackhpc/2024.1 February 3, 2025 14:28
@assumptionsandg assumptionsandg added Caracal Targets the Caracal OpenStack release and removed antelope Targets the Antelope OpenStack release labels Feb 3, 2025
@Alex-Welsh
Copy link
Member

@assumptionsandg ready for review?

@assumptionsandg assumptionsandg added the ansible Ansible playbooks label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Ansible playbooks Caracal Targets the Caracal OpenStack release documentation Improvements or additions to documentation size: l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants