Skip to content

Actually check key type #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Actually check key type #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions etc/kayobe/ansible/cis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,19 @@
tasks:
# TODO: Remove this when Red Hat FIPS policy has been updated to allow ed25519 keys.
# https://gitlab.com/gitlab-org/gitlab/-/issues/367429#note_1840422075
- name: Assert that we are using a supported SSH key
assert:
that:
- ssh_key_type != 'ed25519'
fail_msg: FIPS policy does not currently support ed25519 SSH keys on RHEL family systems
when: ansible_facts.os_family == 'RedHat'
- when: ansible_facts.os_family == 'RedHat'
block:
- name: Check type of key using the file command
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose someone could be using an agent, so maybe I can't make the assumption that this path contains the key.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided just to document this better in terraform-multinode as I don't think we could catch all cases:

stackhpc/terraform-kayobe-multinode#57

raw: file {{ ssh_private_key_path }}
delegate_to: localhost
changed_when: false
register: ssh_key_check

- name: Assert that we are using a supported SSH key
assert:
that:
- ssh_key_check.stdout | regex_search('ed25519', ignorecase=true)
fail_msg: FIPS policy does not currently support ed25519 SSH keys on RHEL family systems

- name: Ensure the cron package is installed on ubuntu
package:
Expand Down
Loading