Skip to content

Fix issue with prometheus and hyphens in blackbox exporter #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

technowhizz
Copy link
Contributor

Fixes an issue where prometheus wasn't happy with hyphens in the names of targets

Fixes an issue where prometheus wasn't happy with hyphens in the names
of targets
@technowhizz technowhizz requested a review from a team as a code owner July 30, 2024 20:43
@technowhizz technowhizz self-assigned this Jul 30, 2024
@technowhizz technowhizz requested a review from Alex-Welsh July 30, 2024 20:43
@bbezak bbezak changed the title Fix issue with prometheus and hyphens Fix issue with prometheus and hyphens in blackbox exporter Aug 2, 2024
@cityofships
Copy link
Member

Before:
image

After:
image

@cityofships cityofships merged commit 02b9ed3 into stackhpc/2023.1 Aug 2, 2024
12 checks passed
@cityofships cityofships deleted the prometheus-blackbox-internal-fix branch August 2, 2024 10:06
@cityofships
Copy link
Member

One more issue is that rabbitmq_enable_tls is not respected / passed correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants