Skip to content

Disable CIS shell timeout #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Disable CIS shell timeout #1223

wants to merge 1 commit into from

Conversation

Alex-Welsh
Copy link
Member

No description provided.

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner August 12, 2024 15:19
markgoddard
markgoddard reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning? Just that it's annoying?

@Alex-Welsh
Copy link
Member Author

What's the reasoning? Just that it's annoying?

Yep, it's just a real pain losing your session constantly

@markgoddard
Copy link
Contributor

What's the reasoning? Just that it's annoying?

Yep, it's just a real pain losing your session constantly

I guess the issue here is we slowly reduce our CIS score over time by disabling these things. Anyone else have thoughts?

@bbezak
Copy link
Member

bbezak commented Aug 19, 2024

What's the reasoning? Just that it's annoying?

Yep, it's just a real pain losing your session constantly

I guess the issue here is we slowly reduce our CIS score over time by disabling these things. Anyone else have thoughts?

SSH connection timeout is important CIS feature. IMHO If we're enabling CIS, SSH connection timeout should stay

@mnasiadka
Copy link
Member

What's the reasoning? Just that it's annoying?

Yep, it's just a real pain losing your session constantly

I guess the issue here is we slowly reduce our CIS score over time by disabling these things. Anyone else have thoughts?

SSH connection timeout is important CIS feature. IMHO If we're enabling CIS, SSH connection timeout should stay

If we're disabling that, we're also lowering the coverage of CIS standard on customer sites - I don't think we can do it just because it's annoying.

@Alex-Welsh Alex-Welsh closed this Aug 19, 2024
@Alex-Welsh Alex-Welsh deleted the cis-disable-timeout branch August 20, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@markgoddard markgoddard markgoddard left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alex-Welsh @markgoddard @bbezak @mnasiadka