Skip to content

fix: use rabbitmq length for RabbitMQNodeDown #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

fix: use rabbitmq length for RabbitMQNodeDown #1579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e183052
fix: use `rabbitmq` length for `RabbitMQNodeDown`
jackhodgkiss Mar 17, 2025
e7282e6
Update etc/kayobe/kolla/config/prometheus/rabbitmq.rules
jackhodgkiss Mar 24, 2025
747181f
feat: add `alertmanager_number_of_rabbitmq_nodes`
jackhodgkiss May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etc/kayobe/kolla/config/prometheus/rabbitmq.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ groups:
- name: rabbitmq.rules
rules:
- alert: RabbitMQNodeDown
expr: sum(rabbitmq_build_info{instance!=""}) < 3
expr: sum(rabbitmq_build_info{instance!=""}) < {% endraw %}{{ alertmanager_number_of_rabbitmq_nodes }}{% raw %}
for: 30m
labels:
severity: critical
Expand Down
3 changes: 3 additions & 0 deletions etc/kayobe/stackhpc-monitoring.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ alertmanager_packet_drop_threshold: 1
# packets/s averaged over 5 minutes.
alertmanager_packet_errors_threshold: 1

# Number of RabbitMQ nodes in the cluster.
alertmanager_number_of_rabbitmq_nodes: "{{ groups['controllers'] | length }}"

###############################################################################
# Exporter configuration

Expand Down
8 changes: 8 additions & 0 deletions releasenotes/notes/use-length-for-rabbitmq-node-down-rule-c9e9c6b09f57954d.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
features:
- |
Allow for easy customisation of the number of expected `RabbitMQ`
nodes when evaluating the alert `RabbitMQNodeDown`. It is set by
the `alertmanager_number_of_rabbitmq_nodes` which defaults to the
number of `controllers`. This is benefical for deployments that
do not use a standard three node setup.
Loading