Add CA choice template to multinode.sh #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2025
Alex-Welsh
reviewed
Jul 4, 2025
There was a problem hiding this comment.
I'd prefer it if we kept this as a regular file rather than a template. It makes it easier to use & debug. Is there another way we could do this?
There was a problem hiding this comment.
We can have two separate multinode.sh. One for openbao and another for vault. Then conditionally copy only one of them to control host?
There was a problem hiding this comment.
From discussions in other channels, we've agreed the best solution would be to unify the playbooks in SKC and make one generic set. For example, we replace openbao-unseal-overcloud.yml and vault-unseal-overcloud.yml with secret-store-unseal-overcloud.yml. We could then have a single variable in SKC to switch between the two types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to choose OpenBao or Hashicorp Vault as the certificate authority.