Skip to content

fix: ensures immediate return in failure of cd script #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix: ensures immediate return in failure of cd script #314

merged 4 commits into from
Nov 25, 2024

Conversation

MelvinKl
Copy link
Contributor

No description provided.

joaopalet
joaopalet approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@joaopalet joaopalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if they specified the actual rate limiting values, but at least now we get alerted

@MelvinKl MelvinKl merged commit 8b5381e into main Nov 25, 2024
12 checks passed
@MelvinKl MelvinKl deleted the fix/cd_immediate_return branch November 25, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopalet joaopalet joaopalet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MelvinKl @joaopalet