Skip to content

chore(provider): mark deprecation for service_account_token #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

h3adex
Copy link
Contributor

@h3adex h3adex commented Jul 20, 2025

Description

See
https://docs.stackit.cloud/stackit/en/release-notes-23101442.html
https://docs.stackit.cloud/stackit/en/deprecation-plan-for-service-account-access-tokens-and-migration-guide-373293307.html

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex h3adex requested a review from a team as a code owner July 20, 2025 09:50
Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Jul 29, 2025
@marceljk marceljk removed the Stale PR is marked as stale due to inactivity. label Jul 30, 2025
@h3adex h3adex force-pushed the chore/deprecate-service-account-token-provider-attribute branch from aa31af9 to d797ebd Compare July 31, 2025 13:27
@h3adex h3adex changed the title chore(provider): make deprecation for service_account_token chore(provider): mark deprecation for service_account_token Jul 31, 2025
@h3adex h3adex requested review from marceljk and rubenhoenle July 31, 2025 14:28
@h3adex h3adex force-pushed the chore/deprecate-service-account-token-provider-attribute branch from 6f84988 to f168271 Compare August 4, 2025 09:47
h3adex added 5 commits August 4, 2025 11:50
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
@h3adex h3adex force-pushed the chore/deprecate-service-account-token-provider-attribute branch from f168271 to 5e58423 Compare August 4, 2025 09:51
marceljk
marceljk previously approved these changes Aug 4, 2025
@rubenhoenle
Copy link
Member

There are some further adjustments needed:

1. Setup authentication by setting the env var `STACKIT_SERVICE_ACCOUNT_TOKEN` as a valid token (see [Authentication](#authentication) for more details on how to autenticate).
(contributors should use keyflow instead)


service_account_token = var.service_account_token
(token flow must be marked as deprecated here or can be removed at all)


This is the initial page of the Terraform provider docs, see https://registry.terraform.io/providers/stackitcloud/stackit/latest/docs

### Token flow
Using this flow is less secure since the token is long-lived. You can provide the token in several ways:
1. Setting the field `service_account_token` in the provider
2. Setting the environment variable `STACKIT_SERVICE_ACCOUNT_TOKEN`
3. Setting it in the credentials file (see above)

Copy link
Member

@rubenhoenle rubenhoenle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@rubenhoenle rubenhoenle added the needs-work PR needs changes by the author. label Aug 5, 2025
@rubenhoenle
Copy link
Member

@h3adex fixed my findings for you :)

@marceljk marceljk merged commit 5320e0c into stackitcloud:main Aug 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work PR needs changes by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants