Add manual security group handling and expose SG ID #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the load balancer resource. This allows disabling the automatic assignment of a security group to the targets.
This allows users to reference the ID in security group rules for targets in other networks, enabling cross-network traffic.
This allows users to reference the ID in security group rules for targets in other networks, enabling cross-network traffic.
marceljk
reviewed
Jul 30, 2025
stackit/internal/services/loadbalancer/loadbalancer_acc_test.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/loadbalancer/loadbalancer_acc_test.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/loadbalancer/loadbalancer_acc_test.go
Outdated
Show resolved
Hide resolved
marceljk
reviewed
Aug 6, 2025
docs/resources/loadbalancer.md
Outdated
Comment on lines
197
to
200
| network_interfaces = [{ | ||
| network_id = stackit_network.target_network.id | ||
| security_groups = [stackit_security_group.target_sg.id] | ||
| }] |
There was a problem hiding this comment.
Invalid config. The network_interface attribute takes only network_interface IDs as string. So you need to create manually a "stackit_network_interface" and assign here the network_interface_id of it
There was a problem hiding this comment.
I reworked the example and parts of the way the provider handles the new field, could you test again?
…es ready if disabletargetsecuritygroupassignment is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the stackit_loadbalancer resource by introducing advanced networking capabilities for managing security groups, particularly for cross-network and cross-project use cases.
Two new attributes have been added:
disable_security_group_assignment (Optional, Bool): This new root-level flag allows users to disable the automatic creation and assignment of security groups to the load balancer's targets. This is required when targets are located in a different network or project than the load balancer itself, giving users full control over the networking setup.
security_group_id (Computed, String): This new computed attribute exposes the ID of the load balancer's own internal egress security group. Users can reference this ID in their own security group rules (e.g., as the remote_security_group_id) to manually permit traffic from the load balancer to their targets.
Together, these features enable secure and explicit network configurations for complex architectures. This change includes updates to the resource and data source schemas, all necessary business logic, comprehensive unit and acceptance tests, and updated documentation to guide users through the new workflow.
relates to #1150
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)