Skip to content

Conversation

janisz
Copy link
Collaborator

@janisz janisz commented Aug 29, 2025

A little copying is better than a little dependency.

Since keda does not release it's API as a separated module it has all dependencies that keda requires. This causes problems to update other deps like prometheus API. This PR copy API objects from keda, removes unused part and keep it in the repo.

Error: /home/runner/go/pkg/mod/github.com/kedacore/keda/v2@v2.17.2/apis/keda/v1alpha1/scaledjob_webhook.go:41:15: undefined: webhook.Validator
Error: /home/runner/go/pkg/mod/github.com/kedacore/keda/v2@v2.17.2/apis/keda/v1alpha1/triggerauthentication_webhook.go:52:15: undefined: webhook.Validator
Error: /home/runner/go/pkg/mod/github.com/kedacore/keda/v2@v2.17.2/apis/keda/v1alpha1/triggerauthentication_webhook.go:79:15: undefined: webhook.Validator

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested a review from rhybrillou as a code owner August 29, 2025 10:49
go.opentelemetry.io/otel/metric v1.35.0 // indirect
go.opentelemetry.io/otel/sdk v1.35.0 // indirect
go.opentelemetry.io/otel/sdk/metric v1.35.0 // indirect
go.opentelemetry.io/otel/trace v1.35.0 // indirect
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea why new pacakges appeard as indirect while we mostly remove pacakges

go mod why go.opentelemetry.io/otel
# go.opentelemetry.io/otel
golang.stackrox.io/kube-linter/pkg/lintcontext
helm.sh/helm/v3/pkg/cli/values
helm.sh/helm/v3/pkg/getter
helm.sh/helm/v3/pkg/registry
helm.sh/helm/v3/pkg/registry.test
github.com/distribution/distribution/v3/registry
github.com/distribution/distribution/v3/tracing
go.opentelemetry.io/otel

janisz added 2 commits August 29, 2025 13:08
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested a review from rukletsov September 1, 2025 10:24
Copy link
Contributor

@rhybrillou rhybrillou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the type registration. Otherwise, LGTM

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz merged commit 2010fa0 into main Sep 2, 2025
8 checks passed
@janisz janisz deleted the copy_keda branch September 2, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants