Skip to content

Conversation

@jferrant
Copy link
Contributor

@jferrant jferrant commented Oct 9, 2025

Closes #6578

…ock up

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant requested review from a team as code owners October 9, 2025 14:45
@jferrant jferrant added this pull request to the merge queue Oct 9, 2025
Merged via the queue into stacks-network:develop with commit ece4dac Oct 9, 2025
302 of 303 checks passed
@jferrant jferrant deleted the bugfix/propogate-up-error-in-accept-block branch October 9, 2025 17:34
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.56%. Comparing base (a7f4240) to head (67ce930).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/chainstate/nakamoto/mod.rs 61.11% 7 Missing ⚠️

❌ Your project status has failed because the head coverage (68.56%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6580      +/-   ##
===========================================
+ Coverage    66.00%   68.56%   +2.56%     
===========================================
  Files          568      568              
  Lines       347674   347667       -7     
===========================================
+ Hits        229495   238392    +8897     
+ Misses      118179   109275    -8904     
Files with missing lines Coverage Δ
stackslib/src/chainstate/nakamoto/mod.rs 80.31% <61.11%> (+0.46%) ⬆️

... and 359 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f4240...67ce930. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants