aac: update epoch list configuration from epoch20#6611
aac: update epoch list configuration from epoch20#6611federico-stacks wants to merge 3 commits intostacks-network:developfrom
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6611 +/- ##
===========================================
+ Coverage 79.88% 80.67% +0.78%
===========================================
Files 571 571
Lines 351586 351590 +4
===========================================
+ Hits 280856 283634 +2778
+ Misses 70730 67956 -2774
... and 81 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@jacinta-stacks do we want to merge this PR in the end, instead of using it just as reference for your pr (#6619)? Not problem on my side if it is the case. Just let me know, so I can fix the going conflicts. |
|
superseded by #6619 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR is mainly a wrap-up of what we discussed during our last internal sync. It introduce a very small change concerning the epoch list creation, taking into account epoch 2.X.
Here a sum-up of the points we discussed:
contract_deploy_consensus_test!andcontract_call_consensus_test!macros should be sufficient.If this reasoning is correct, considering the small change introduced in this PR would we prefer to integrate it directly into #6608 instead?
Otherwise, I’m happy to adjust and implement any missing pieces based on your feedback.
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo