add miner diagnostic to block proposal data

[benjamin-stacks]

The exact list of things that should be included in the diagnostics data is up for debate -- please opine on what things might be useful.

https://github.com/stx-labs/core-epics/issues/194

[hstove-stacks]

This plan makes sense to me! My main request is to add unit tests with existing block proposal fixtures (ie hex serialized versions) and do simple round-trip serialization tests. That's helped catch footguns in the past with these kinds of things.

Edit: I'm sure you've seen this, but for one change I just copy/pasted the old implementation into our tests, as a simple way of testing backwards compatibility.

[benjamin-stacks]

My main request is to add unit tests with existing block proposal fixtures (ie hex serialized versions) and do simple round-trip serialization tests.

I already added some such tests for the BlockProposalData specifically. I can also add some more tests to the wrapping type, although I think it wouldn't add any new practical coverage. I may be wrong.

[hstove-stacks]

Ah yes I do now see that we already have that kind of test, so you wouldn't be adding new coverage. Great!

[codecov]

Codecov Report

❌ Patch coverage is 91.30435% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.98%. Comparing base (220840e) to head (6d25e87).
⚠️ Report is 254 commits behind head on develop.

Files with missing lines	Patch %	Lines
stacks-node/src/nakamoto_node/miner.rs	80.00%	4 Missing ⚠️
stacks-common/src/types/mod.rs	91.17%	3 Missing ⚠️
libsigner/src/events.rs	97.22%	1 Missing ⚠️

❌ Your project status has failed because the head coverage (84.98%) is below the adjusted base coverage (84.99%). You can increase the head coverage or adjust the Removed Code Behavior.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6989      +/-   ##
===========================================
- Coverage    84.99%   84.98%   -0.02%     
===========================================
  Files          412      412              
  Lines       219958   220044      +86     
  Branches       338      338              
===========================================
+ Hits        186959   186996      +37     
- Misses       32999    33048      +49     

Files with missing lines	Coverage Δ
...tacks-node/src/nakamoto_node/signer_coordinator.rs	86.48% <100.00%> (-0.24%)	⬇️
libsigner/src/events.rs	90.02% <97.22%> (+0.56%)	⬆️
stacks-common/src/types/mod.rs	83.44% <91.17%> (+0.44%)	⬆️
stacks-node/src/nakamoto_node/miner.rs	87.07% <80.00%> (+0.20%)	⬆️

... and 40 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 220840e...6d25e87. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.