-
-
Notifications
You must be signed in to change notification settings - Fork 36
use posterior::gpdfit and posterior::qgeneralized_pareto() #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the R cmd check error is because the NAMESPACE file is still trying to export gpdfit from loo. If you run devtools::document() it should fix this and then we can see if all the tests pass.
If it has been exported, then someone might be using it? Should I put it back and define it with posterior::qgeneralized_pareto()? |
At least in github only I and Juho Timonen have used loo::gpdfit, so I guess it can be removed |
Good point. Yeah you can just replace the bodies of the functions with calls to the posterior versions. |
OK in that case, we can try removing it and we will find out in the reverse dependency checks whether any packages are using it |
The error now is because apparently these functions aren't exported from posterior, they're just internal functions. That would be easy to change but it would require doing a CRAN release of posterior. |
my bad, I guess this needs to wait for the next posterior release |
There is also #290 from @VisruthSK that is waiting to be merged until there is a new release of posterior |
Since we do use
posterior
package elsewhere,replace gpdfit() and qgpd() with posterior::gpdfit and posterior::qgeneralized_pareto()
This will make maintenance easier. For example, there is a PR for posterior::gpdfit() to make it more robust and posterior::qgeneralized_pareto() already is more robust than qgpd()
This is related to #249, but timing is due to the fix PR for posterior::gpdfit()