Surpress a DeprecationWarning about pkg_resource from jieba. #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, looks grim. I wonder if we should just cut out support for it at
some point. I sure don't want to fork jieba myself
Let me consider for a bit. Probably just merge the temporary patch for now
…On Fri, May 16, 2025 at 7:03 PM otakutyrant ***@***.***> wrote:
Fix #1490 <#1490>
jieba has been unmaintained for five years, so it impossible to fix it in
the upstream. This fix just ignores the warning explicitly.
------------------------------
You can view, comment on, or merge this pull request online at:
#1492
Commit Summary
- 00b7bbe
<00b7bbe>
Surpress a DeprecationWarning about pkg_resource from jieba.
File Changes
(1 file <https://github.com/stanfordnlp/stanza/pull/1492/files>)
- *M* stanza/pipeline/external/jieba.py
<https://github.com/stanfordnlp/stanza/pull/1492/files#diff-ed3e99f43261f84cd9ea6df6bc974a99aa013bf30dd5201bdc66aa31b3be4fb8>
(9)
Patch Links:
- https://github.com/stanfordnlp/stanza/pull/1492.patch
- https://github.com/stanfordnlp/stanza/pull/1492.diff
—
Reply to this email directly, view it on GitHub
<#1492>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2AYWMTK3ECP4VAOE7HSID262KFRAVCNFSM6AAAAAB5KALYACVHI2DSMVQWIX3LMV43ASLTON2WKOZTGA3TAMJXGU4DQMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I feel like this is a ticking time bomb which will one day fail when jieba is deprecated... but I suppose the unit test will tell us when that happens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1490
jieba has been unmaintained for five years, so it impossible to fix it in the upstream. This fix just ignores the warning explicitly.