fix getEnvVar non default val (#157)

puncsky · web-flow · commit 3ad944b84f9a · 2021-01-06T15:17:25.000-08:00
diff --git a/packages/web-server/src/env-var.ts b/packages/web-server/src/env-var.ts
@@ -4,8 +4,8 @@ config();
 
 export function getEnvVar(
   varName: string,
-  defaultValue: string,
-  isHardDependency = false
+  defaultValue?: string,
+  isHardDependency?: boolean
 ): string {
   const val = process.env[varName];
   if (!val) {
@@ -19,5 +19,5 @@ export function getEnvVar(
       );
     }
   }
-  return val || defaultValue;
+  return (val !== undefined ? val : defaultValue) || "";
 }

Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,8 @@ config();`
`4`	`4`
`5`	`5`	`export function getEnvVar(`
`6`	`6`	`varName: string,`
`7`		`- defaultValue: string,`
`8`		`- isHardDependency = false`
	`7`	`+ defaultValue?: string,`
	`8`	`+ isHardDependency?: boolean`
`9`	`9`	`): string {`
`10`	`10`	`const val = process.env[varName];`
`11`	`11`	`if (!val) {`
`@@ -19,5 +19,5 @@ export function getEnvVar(`
`19`	`19`	`);`
`20`	`20`	`}`
`21`	`21`	`}`
`22`		`- return val \|\| defaultValue;`
	`22`	`+ return (val !== undefined ? val : defaultValue) \|\| "";`
`23`	`23`	`}`