fix: snip29 - timeBounds seconds (number), public preparePaymasterTransaction (#1408)

* fix: time bounds are now in seconds

* fix: preparePaymasterTransaction is now public

* docs: add time bounds comments

* fix: bump types-js

* fix: executeAfter is optional -> execute immediately

Author: 0xlny

package-lock.json

@@ -106,7 +106,7 @@
     "lossless-json": "^4.0.1",
     "pako": "^2.0.4",
     "@starknet-io/starknet-types-07": "npm:@starknet-io/types-js@~0.7.10",
-    "@starknet-io/starknet-types-08": "npm:@starknet-io/types-js@~0.8.3",
+    "@starknet-io/starknet-types-08": "npm:@starknet-io/types-js@~0.8.4",
     "ts-mixer": "^6.0.3"
   },
   "engines": {

package.json

@@ -455,7 +455,7 @@ export class Account extends Provider implements AccountInterface {
     return preparedTransaction.fee;
   }
 
-  private async preparePaymasterTransaction(
+  public async preparePaymasterTransaction(
     preparedTransaction: PreparedTransaction
   ): Promise<ExecutableUserTransaction> {
     let transaction: ExecutableUserTransaction;

src/account/default.ts

@@ -268,9 +268,9 @@ export abstract class AccountInterface extends ProviderInterface {
    * - calldata - (defaults to []) the calldata
    *
    * @param paymasterDetails the paymaster details containing:
-   * - feeMode - the fee mode
+   * - feeMode - the fee mode (sponsored or default)
    * - deploymentData - the deployment data (optional)
-   * - timeBounds - the time bounds (optional)
+   * - timeBounds - the time bounds when the transaction is valid (optional) - executeAfter and executeBefore expected to be in seconds (BLOCK_TIMESTAMP)
    *
    * @param maxFeeInGasToken - the max fee acceptable to pay in gas token (optional)
    *

src/account/interface.ts

@@ -45,18 +45,18 @@ const convertFEE_MODE = (feeMode: PAYMASTER_API.FEE_MODE): FeeMode => {
 };
 
 const convertTimeBounds = (timeBounds?: PaymasterTimeBounds): TIME_BOUNDS | undefined =>
-  timeBounds && timeBounds.executeAfter && timeBounds.executeBefore
+  timeBounds
     ? {
-        execute_after: timeBounds.executeAfter.getTime().toString(),
-        execute_before: timeBounds.executeBefore.getTime().toString(),
+        execute_after: timeBounds.executeAfter || 1, // If executeAfter is not provided, set it to 1, meaning the transaction can be executed immediately
+        execute_before: timeBounds.executeBefore,
       }
     : undefined;
 
 const convertTIME_BOUNDS = (timeBounds?: TIME_BOUNDS): PaymasterTimeBounds | undefined =>
-  timeBounds && timeBounds.execute_after && timeBounds.execute_before
+  timeBounds
     ? {
-        executeAfter: new Date(timeBounds.execute_after),
-        executeBefore: new Date(timeBounds.execute_before),
+        executeAfter: timeBounds.execute_after,
+        executeBefore: timeBounds.execute_before,
       }
     : undefined;
 

src/paymaster/rpc.ts

@@ -93,7 +93,8 @@ export type ExecutionParameters = {
   timeBounds?: PaymasterTimeBounds;
 };
 
+// executeBefore & executeAfter are in seconds, and is compared to the current block timestamp (see https://docs.starknet.io/architecture-and-concepts/network-architecture/block-structure/)
 export interface PaymasterTimeBounds {
-  executeAfter?: Date;
-  executeBefore?: Date;
+  executeAfter?: number; // executeAfter is optional, if not provided, it will be set to 1, meaning the transaction can be executed immediately
+  executeBefore: number; // executeBefore is mandatory if timeBounds is provided
 }