Typed data enum fixes (SNIP-12) #1292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: missing snip-12 enum type dependency * test: add nested enum tests --------- Co-authored-by: Petar Penovic <pp@spaceshard.io>
xJonathanLEI
added a commit
to xJonathanLEI/starknet-rs
that referenced
this pull request
Mar 20, 2025
The expected hash is based on a patched version of starknet.js at:
starknet-io/starknet.js#1292
xJonathanLEI
added a commit
to xJonathanLEI/starknet-rs
that referenced
this pull request
Mar 20, 2025
The expected hash is based on a patched version of starknet.js at:
starknet-io/starknet.js#1292
xJonathanLEI
added a commit
to xJonathanLEI/starknet-rs
that referenced
this pull request
Mar 20, 2025
* test: add snip-12 simple enum test case
The expected hash is based on a patched version of starknet.js at:
starknet-io/starknet.js#1292
* feat: port starknet.js SNIP-12 deviations
Just released it as the v6.24.1 pre-release. it will be promoted as a main release before the v7 beta with RPC 0.8 support is promoted to a pre-release, so should be relatively soon. |
|
@penovicp Should convert this to a draft while we agree on the new revision? |
|
Superseded by #1413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Aggregate for the typed data enum fixes. Extracted so potential impact can be coordinated and so that less impactful prereleases can proceed unhindered.
Aggregated PRs:
:in enum encoding #1288Corresponding issues: