Skip to content

Commit e4474dd

Browse files
committed
mempool_test_utils: remove test_resource_bounds_mapping
1 parent 58b8a20 commit e4474dd

File tree

2 files changed

+4
-29
lines changed

2 files changed

+4
-29
lines changed

crates/apollo_integration_tests/tests/test_custom_cairo1_txs.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ use blockifier_test_utils::cairo_versions::{CairoVersion, RunnableCairo1};
55
use blockifier_test_utils::calldata::create_calldata;
66
use blockifier_test_utils::contracts::FeatureContract;
77
use mempool_test_utils::starknet_api_test_utils::{
8-
test_resource_bounds_mapping,
98
AccountTransactionGenerator,
109
MultiAccountTransactionGenerator,
1110
};
@@ -14,6 +13,7 @@ use starknet_api::abi::abi_utils::selector_from_name;
1413
use starknet_api::core::{calculate_contract_address, CompiledClassHash};
1514
use starknet_api::rpc_transaction::RpcTransaction;
1615
use starknet_api::test_utils::invoke::rpc_invoke_tx;
16+
use starknet_api::test_utils::resource_bounds_for_testing;
1717
use starknet_api::transaction::fields::{ContractAddressSalt, Tip};
1818
use starknet_api::transaction::TransactionVersion;
1919
use starknet_api::{calldata, felt};
@@ -230,7 +230,7 @@ fn generate_test_get_execution_info_without_block_info_invoke_tx(
230230
let fn_name = "test_get_execution_info_without_block_info";
231231
let test_contract = FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm));
232232

233-
let resources_bounds_values = test_resource_bounds_mapping();
233+
let resources_bounds_values = resource_bounds_for_testing();
234234
let calldata = vec![
235235
TransactionVersion::THREE.0, // version
236236
*account_tx_generator.sender_address().0.key(), // account address

crates/mempool_test_utils/src/starknet_api_test_utils.rs

Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,8 @@ use blockifier_test_utils::contracts::FeatureContract;
1111
use papyrus_base_layer::ethereum_base_layer_contract::L1ToL2MessageArgs;
1212
use papyrus_base_layer::test_utils::DEFAULT_ANVIL_L1_ACCOUNT_ADDRESS;
1313
use starknet_api::abi::abi_utils::selector_from_name;
14-
use starknet_api::block::GasPrice;
1514
use starknet_api::core::{ClassHash, CompiledClassHash, ContractAddress, Nonce};
1615
use starknet_api::executable_transaction::{AccountTransaction, DeclareTransaction};
17-
use starknet_api::execution_resources::GasAmount;
1816
use starknet_api::hash::StarkHash;
1917
use starknet_api::rpc_transaction::RpcTransaction;
2018
use starknet_api::state::SierraContractClass;
@@ -26,22 +24,17 @@ use starknet_api::test_utils::invoke::{
2624
InvokeTxArgs,
2725
};
2826
use starknet_api::test_utils::{
27+
resource_bounds_for_testing,
2928
NonceManager,
3029
TEST_ERC20_CONTRACT_ADDRESS2,
31-
VALID_L1_DATA_GAS_MAX_AMOUNT,
32-
VALID_L1_DATA_GAS_MAX_PRICE_PER_UNIT,
33-
VALID_L1_GAS_MAX_AMOUNT,
34-
VALID_L1_GAS_MAX_PRICE_PER_UNIT,
3530
VALID_L2_GAS_MAX_AMOUNT,
3631
VALID_L2_GAS_MAX_PRICE_PER_UNIT,
3732
};
3833
use starknet_api::transaction::constants::TRANSFER_ENTRY_POINT_NAME;
3934
use starknet_api::transaction::fields::{
40-
AllResourceBounds,
4135
Calldata,
4236
ContractAddressSalt,
4337
Fee,
44-
ResourceBounds,
4538
Tip,
4639
TransactionSignature,
4740
ValidResourceBounds,
@@ -66,26 +59,8 @@ pub const TIP_FOR_TESTING: Tip = Tip(1);
6659

6760
// Utils.
6861

69-
// TODO(Noam): Merge this into test_valid_resource_bounds
70-
pub fn test_resource_bounds_mapping() -> AllResourceBounds {
71-
AllResourceBounds {
72-
l1_gas: ResourceBounds {
73-
max_amount: GasAmount(VALID_L1_GAS_MAX_AMOUNT),
74-
max_price_per_unit: GasPrice(VALID_L1_GAS_MAX_PRICE_PER_UNIT),
75-
},
76-
l2_gas: ResourceBounds {
77-
max_amount: GasAmount(VALID_L2_GAS_MAX_AMOUNT),
78-
max_price_per_unit: GasPrice(VALID_L2_GAS_MAX_PRICE_PER_UNIT),
79-
},
80-
l1_data_gas: ResourceBounds {
81-
max_amount: GasAmount(VALID_L1_DATA_GAS_MAX_AMOUNT),
82-
max_price_per_unit: GasPrice(VALID_L1_DATA_GAS_MAX_PRICE_PER_UNIT),
83-
},
84-
}
85-
}
86-
8762
pub fn test_valid_resource_bounds() -> ValidResourceBounds {
88-
ValidResourceBounds::AllResources(test_resource_bounds_mapping())
63+
ValidResourceBounds::AllResources(resource_bounds_for_testing())
8964
}
9065

9166
/// Get the contract class used for testing.

0 commit comments

Comments
 (0)