-
Couldn't load subscription status.
- Fork 64
apollo_l1_provider: remove panic on unknown L1 event type; add support for cancellations #9776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_l1_provider: remove panic on unknown L1 event type; add support for cancellations #9776
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
919369b to
384739b
Compare
…t for cancellations
384739b to
f181e74
Compare
|
Why is this a panic? Code quote: panic!(
"Double consumption of {tx_hash} at {consumed_at}, previously \
consumed at {previously_consumed_at}."
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @ShahakShama)
crates/apollo_l1_provider/src/l1_provider.rs line 248 at r1 (raw file):
Previously, dan-starkware wrote…
Why is this a panic?
I am not sure. I will ask Gilad, maybe he remembers the reason.
It is generally not supposed to happen...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan-starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)
…t for cancellations (#9776)

No description provided.