Skip to content

Conversation

@guy-starkware
Copy link
Contributor

No description provided.

@guy-starkware guy-starkware marked this pull request as ready for review October 26, 2025 15:43
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

@guy-starkware guy-starkware force-pushed the guyn/l1provider/dont_panic_on_unexpected_events branch from 919369b to 384739b Compare October 27, 2025 08:23
@guy-starkware guy-starkware changed the title apollo_l2_provider: remove panic on unknown L1 event type; add support for cancellations apollo_l1_provider: remove panic on unknown L1 event type; add support for cancellations Oct 27, 2025
@guy-starkware guy-starkware force-pushed the guyn/l1provider/dont_panic_on_unexpected_events branch from 384739b to f181e74 Compare October 27, 2025 08:25
@dan-starkware
Copy link
Collaborator

crates/apollo_l1_provider/src/l1_provider.rs line 248 at r1 (raw file):

                            "Double consumption of {tx_hash} at {consumed_at}, previously \
                             consumed at {previously_consumed_at}."
                        );

Why is this a panic?

Code quote:

                        panic!(
                            "Double consumption of {tx_hash} at {consumed_at}, previously \
                             consumed at {previously_consumed_at}."
                        );

Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @ShahakShama)


crates/apollo_l1_provider/src/l1_provider.rs line 248 at r1 (raw file):

Previously, dan-starkware wrote…

Why is this a panic?

I am not sure. I will ask Gilad, maybe he remembers the reason.
It is generally not supposed to happen...

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@dan-starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@guy-starkware guy-starkware added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main-v0.14.0 with commit fcd2498 Oct 27, 2025
16 checks passed
matanl-starkware pushed a commit that referenced this pull request Oct 27, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 27, 2025
…t for cancellations (#9776) (#9800)

Co-authored-by: guy-starkware <guy.n@starkware.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants