Skip to content

Conversation

@Itay-Tsabary-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadin-Starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)


crates/apollo_dashboard/src/dashboard.rs line 446 at r1 (raw file):

// For a given request label and vector of labeled histogram metrics, create a panel with multiple
// expressions.
pub(crate) fn get_multi_metric_panel(

Why?

Code quote:

pub(crate)

crates/apollo_dashboard/src/dashboard.rs line 549 at r1 (raw file):

}

pub(crate) fn get_labeled_client_panels(

Why?

Code quote:

pub(crate)

crates/apollo_dashboard/src/dashboard.rs line 559 at r1 (raw file):

}

pub(crate) fn get_labeled_server_panels(

Why?

Code quote:

pub(crate)

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nadin-Starkware)


crates/apollo_dashboard/src/dashboard.rs line 446 at r1 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Why?

It has higher visibility than needed. Why not?


crates/apollo_dashboard/src/dashboard.rs line 549 at r1 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Why?

Same


crates/apollo_dashboard/src/dashboard.rs line 559 at r1 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Why?

Same

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main-v0.14.1 with commit c1285fd Oct 27, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants