Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Nov 3, 2025

@dorimedini-starkware dorimedini-starkware self-assigned this Nov 3, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review November 3, 2025 20:07
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [14.407 ms 14.581 ms 14.764 ms] change: [-9.7681% -7.4197% -5.2754%] (p = 0.00 < 0.05) Performance has improved.

@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_generate_aggregator_test_input branch from e882e0f to 9ef029f Compare November 4, 2025 08:00
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_migrate_test_aggregator branch from f9dc627 to 938f385 Compare November 4, 2025 08:00
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_migrate_test_aggregator branch from 938f385 to a150ee8 Compare November 4, 2025 08:14
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_generate_aggregator_test_input branch from 9ef029f to 2651d68 Compare November 4, 2025 09:00
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_migrate_test_aggregator branch from a150ee8 to 9a6f3c4 Compare November 4, 2025 09:00
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_generate_aggregator_test_input branch from 2651d68 to 4b57b89 Compare November 4, 2025 09:29
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_migrate_test_aggregator branch from 9a6f3c4 to 75e685e Compare November 4, 2025 09:29
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_generate_aggregator_test_input branch from 4b57b89 to 79b20ca Compare November 4, 2025 09:32
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_migrate_test_aggregator branch from 75e685e to e7fa4d0 Compare November 4, 2025 09:34
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_generate_aggregator_test_input branch from 79b20ca to fd03221 Compare November 4, 2025 09:38
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_migrate_test_aggregator branch from e7fa4d0 to ded2ac0 Compare November 4, 2025 09:38
Copy link
Contributor

@einat-starkware einat-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@einat-starkware reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@dorimedini-starkware dorimedini-starkware changed the base branch from 11-03-starknet_os_generate_aggregator_test_input to main November 4, 2025 13:12
@dorimedini-starkware dorimedini-starkware force-pushed the 11-03-starknet_os_migrate_test_aggregator branch from ded2ac0 to 270bf45 Compare November 4, 2025 13:12
@graphite-app
Copy link

graphite-app bot commented Nov 4, 2025

Merge activity

  • Nov 4, 1:12 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 0316394 Nov 4, 2025
30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants