Modify finalize of DomainEvaluationAccumulator. #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
leo-starkware
force-pushed
the
leo/accumulation_1
branch
from
49abe54 to
eb034d5
Compare
leo-starkware
force-pushed
the
leo/accumulation_0
branch
from
eefb2b0 to
38b80ce
Compare
leo-starkware
force-pushed
the
leo/accumulation_1
branch
from
eb034d5 to
b7a410c
Compare
leo-starkware
force-pushed
the
leo/accumulation_0
branch
from
38b80ce to
aa52a20
Compare
leo-starkware
force-pushed
the
leo/accumulation_1
branch
from
b7a410c to
440795d
Compare
leo-starkware
force-pushed
the
leo/accumulation_0
branch
from
aa52a20 to
7d53619
Compare
leo-starkware
force-pushed
the
leo/accumulation_1
branch
from
440795d to
33d634c
Compare
leo-starkware
force-pushed
the
leo/accumulation_0
branch
from
7d53619 to
3eff44a
Compare
leo-starkware
force-pushed
the
leo/accumulation_1
branch
3 times, most recently
from
69a16e0 to
20b6223
Compare
leo-starkware
force-pushed
the
leo/accumulation_0
branch
from
3eff44a to
4a48efa
Compare
leo-starkware
force-pushed
the
leo/accumulation_1
branch
2 times, most recently
from
b284e21 to
85a8803
Compare
leo-starkware
force-pushed
the
leo/accumulation_0
branch
3 times, most recently
from
0640bfd to
0726974
Compare
leo-starkware
force-pushed
the
leo/accumulation_1
branch
from
85a8803 to
eb2f5cb
Compare
alon-f
approved these changes
Nov 24, 2025
Contributor
alon-f
left a comment
alon-f
left a comment
There was a problem hiding this comment.
@alon-f reviewed 7 of 7 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Gali-StarkWare)
leo-starkware
force-pushed
the
leo/accumulation_1
branch
from
eb2f5cb to
904e82b
Compare
leo-starkware
force-pushed
the
leo/accumulation_1
branch
from
904e82b to
88a7b92
Compare
leo-starkware
commented
Nov 27, 2025
| let mut accumulator = DomainEvaluationAccumulator::<CpuBackend>::new( | ||
| alpha, | ||
| LOG_SIZE_BOUND, | ||
| LOG_SIZE_BOUND - 1, |
Contributor
Author
There was a problem hiding this comment.
The bound in the old version should also be LOG_SIZE_BOUND - 1, but the old finalize is not sensitive as long as the bound is larger than the actual max log size, so the test passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.