[6.x] Handle validation rules on Files fieldtype#14262
Merged
jasonvarga merged 1 commit into6.xfrom Mar 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the Files fieldtype would throw a 500 error when using
min_filesizeormax_filesizevalidation rules.This was happening because the Files fieldtype doesn't have a
fieldRules()method to map these custom validation rules to their corresponding Rule classes. When rules likemax_filesize:10240were passed to Laravel's validator, it tried to find avalidateMaxFilesizemethod which doesn't exist.This PR fixes it by defending a
fieldRules()method on the Files fieldtype, just like we do on the Assets fieldtype.Fixes #14083