Skip to content

[core] Add basic support for state invariant#4944

Closed
davidkpiano wants to merge 7 commits into
mainfrom
davidkpiano/state-invariants
Closed

[core] Add basic support for state invariant#4944
davidkpiano wants to merge 7 commits into
mainfrom
davidkpiano/state-invariants

Conversation

@davidkpiano
Copy link
Copy Markdown
Member

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 16, 2024

⚠️ No Changeset found

Latest commit: b64e763

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need such tests:

  • show the behavior of those invariants for transitions within states that already have invariant, the current tests only show what's the behavior when entering such states
  • show that invariant doesn't create a problems when we exit a state that has some invariant requirement (like, the invariant requires context.user but an exit action within the exited state resets the user to null)
  • show the interactions with entry, always and parallel

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added most of these

Comment thread packages/core/test/invariant.test.ts Outdated
@davidkpiano davidkpiano marked this pull request as ready for review August 20, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants