Skip to content

chore: update the forgot-password modal verbiage #22436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

chore: update the forgot-password modal verbiage #22436

wants to merge 3 commits into from

Conversation

seanstrom
Copy link
Member

fixes #21849

Summary

  • This PR attempts to update the verbiage for the "forgot password" modal that can appear from the login screen

Platforms

  • Android
  • iOS

Areas that may be impacted

Functional

  • Forgot password modal

Steps to test

  • Open Status
  • Attempt to login to a profile using the wrong password
  • Press on the "Forgot Password" link text

Screen Capture

Screen.Recording.2025-04-03.at.14.53.05.mov

status: ready

@seanstrom seanstrom self-assigned this Apr 3, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Apr 3, 2025 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d13bcca #1 2025-04-03 14:19:17 ~5 min tests 📄log
✔️ d13bcca #1 2025-04-03 14:20:15 ~6 min android-e2e 🤖apk 📲
✔️ d13bcca #1 2025-04-03 14:22:33 ~9 min android 🤖apk 📲
✔️ d13bcca #1 2025-04-03 14:25:01 ~11 min ios 📱ipa 📲
✔️ 1f1a1a6 #3 2025-05-19 13:42:26 ~5 min tests 📄log
✔️ 1f1a1a6 #3 2025-05-19 13:46:05 ~8 min android-e2e 🤖apk 📲
✔️ 1f1a1a6 #3 2025-05-19 13:46:38 ~9 min android 🤖apk 📲
✔️ 1f1a1a6 #3 2025-05-19 13:49:37 ~12 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8be9533 #4 2025-05-19 16:21:23 ~4 min tests 📄log
✔️ 8be9533 #4 2025-05-19 16:24:19 ~7 min android 🤖apk 📲
✔️ 8be9533 #4 2025-05-19 16:24:51 ~8 min android-e2e 🤖apk 📲
✔️ 8be9533 #4 2025-05-19 16:28:54 ~12 min ios 📱ipa 📲
✔️ b2f5185 #5 2025-05-20 06:02:25 ~4 min tests 📄log
✔️ b2f5185 #5 2025-05-20 06:04:41 ~7 min android-e2e 🤖apk 📲
✔️ b2f5185 #5 2025-05-20 06:06:37 ~8 min android 🤖apk 📲
✔️ b2f5185 #5 2025-05-20 06:09:38 ~11 min ios 📱ipa 📲

ilmotta
ilmotta approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @seanstrom 💯

Might be worth mentioning to the user that some data loss may be inevitable. Setting up a new profile from the seed phrase won't magically reimport everything, even though that's what a user might naturally expect.

This PR ties in nicely with the goal of offering a backup feature for users. Ideally, the user would create a backup before deleting their profile, so if they change their mind later, they can recover. Another example: imagine the user finds the paper with their password after deleting the profile. The backup/recover feature would help with this scenario.

@seanstrom
Copy link
Member Author

@ilmotta yeah good points about helping the user understand that data recovery is not perfect.
@xAlisher do you have any thoughts on this?

@xAlisher
Copy link

@ilmotta yeah good points about helping the user understand that data recovery is not perfect. @xAlisher do you have any thoughts on this?

Agreed, make sense to mention that some data might be lost.

@churik churik moved this from REVIEW to E2E Tests in Pipeline for QA Apr 16, 2025
@churik churik moved this from E2E Tests to CONTRIBUTOR in Pipeline for QA Apr 16, 2025
@churik
Copy link
Member

churik commented May 12, 2025

@seanstrom what's your take on this? may be let's try to finish it until release cut

@xAlisher
Copy link

image
https://www.figma.com/design/o4qG1bnFyuyFOvHQVGgeFY/Onboarding----Mobile?node-id=17007-28113&t=RGVhFIdzJ5IQqsAU-1

Proposal for update

cc @pedro-et

@xAlisher xAlisher self-assigned this May 13, 2025
@xAlisher xAlisher added this to Design May 13, 2025
@xAlisher xAlisher moved this to 🚧In Progress in Design May 13, 2025
@churik
Copy link
Member

churik commented May 19, 2025

@seanstrom let's do it like this? I'm totally agree on the proposal from @xAlisher , thanks!

@seanstrom seanstrom force-pushed the seanstrom/update-forgot-password-verbiage branch 3 times, most recently from 1f1a1a6 to 8be9533 Compare May 19, 2025 16:16
@seanstrom
Copy link
Member Author

Oki doki 🧑‍🌾

I've updated the verbiage with the latest proposal in this PR, here's how it looks:

Screenshot 2025-05-19 at 17 22 13

@seanstrom seanstrom force-pushed the seanstrom/update-forgot-password-verbiage branch from 8be9533 to b2f5185 Compare May 20, 2025 05:57
@seanstrom seanstrom moved this from CONTRIBUTOR to E2E Tests in Pipeline for QA May 20, 2025
@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 24
Failed tests: 1
Expected to fail tests: 0
Passed tests: 23

IDs of failed tests: 741841

Failed tests (1)

Click to expand
  • Rerun failed tests

    • Class TestWalletCollectibles:

    1. test_wallet_collectible_send_from_expanded_info_view, id: 741841

    Device 1: Find `CollectibleItemElement` by `xpath`: `//*[@content-desc='collectible-list-item']//*[contains(@text,'Glitch Punks')]/../..`
    Device 1: Find `CollectibleItemElement` by `xpath`: `//*[@content-desc='collectible-list-item']//*[contains(@text,'Glitch Punks')]/../..` 

    wallet/test_collectibles.py:159: in test_wallet_collectible_send_from_expanded_info_view
    self.wallet_view.get_collectible_element('Glitch Punks').scroll_and_click()
../views/base_element.py:209: in scroll_and_click
    self.scroll_to_element(direction=direction)
../views/base_element.py:204: in scroll_to_element
    raise NoSuchElementException(
 Device 1: CollectibleItemElement by xpath: `//*[@content-desc='collectible-list-item']//*[contains(@text,'Glitch Punks')]/../..` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Passed tests (23)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_swap_flow_mainnet, id: 741555
    Device sessions

    2. test_wallet_balance_mainnet, id: 740490
    Device sessions

    3. test_wallet_bridge_flow_mainnet, id: 741612
    Device sessions

    4. test_wallet_send_flow_mainnet, id: 741554
    Device sessions

    Class TestWalletCustomParamOneDevice:

    1. test_send_snt_custom_tx_params, id: 742910
    Device sessions

    Class TestProfileMultipleDevices:

    1. test_profile_change_profile_photo, id: 741969
    Device sessions

    2. test_profile_change_username, id: 741968
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletCollectibles:

    1. test_wallet_send_collectible, id: 741840
    Device sessions

    2. test_wallet_collectibles_balance, id: 741839
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_delete, id: 702839
    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    3. test_community_one_image_send_reply_set_reaction, id: 702859
    Device sessions

    4. test_community_message_edit, id: 702843
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_send_eth[Status Network Sepolia-0.0002], id: 727229
    Device sessions

    2. test_wallet_send_erc20_from_drawer[Sepolia-USD Coin-USDC (EVM)-2-0.01], id: 742016
    Device sessions

    3. test_wallet_send_erc20_from_drawer[Optimism Sepolia-USD Coin-USDC (EVM)-2-0.01], id: 727230
    Device sessions

    4. test_send_eth[Arbitrum Sepolia-0.0001], id: 742015
    Device sessions

    Class TestWalletOneDeviceTwo:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    @seanstrom
    Copy link
    Member Author

    @churik is it alright if we skip manual QA? I pre-emptively marked this as skippable, since it seemed like a small UI change, but what do you think?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Awaiting requested review from Parveshdhull

    2 more reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @ulisesmac ulisesmac ulisesmac approved these changes

    Reviewers whose approvals may not affect merge requirements

    At least 1 approving review is required to merge this pull request.

    Assignees

    @seanstrom seanstrom

    @xAlisher xAlisher

    Labels
    design mobile-core skip-manual-qa
    Projects
    Design
    Status: 🚧In Progress
    Pipeline for QA
    Status: E2E Tests
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Update the text in the "Forgot your password" drawer
    6 participants
    @seanstrom @status-im-auto @xAlisher @churik @ilmotta @ulisesmac