feat_: implement onLowMemory and onTrimMemory for android #22540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfrank
changed the title
Jenkins BuildsClick to see older builds (16)
|
|
Tried running this PR build on checked go logs, it seems to avoid android OS thinking Status as |
in case of notification enabled, no killing after 5+ hours, switch Status back to foreground normally |
|
@qfrank |
Parveshdhull
approved these changes
May 13, 2025
There was a problem hiding this comment.
Thank you @qfrank for your awesome work. PR looks good to me
100% of end-end tests have passedNot executed tests (2)Passed tests (22)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDeviceTwo:
Class TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletCollectibles:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestProfileMultipleDevices:
Class TestWalletOneDevice:
|
qfrank
force-pushed
the
frank/chore/low-memory
branch
from
09625ff to
0115348
Compare
put Status into background, cpu usage is around 6%, after |
|
Hi @qfrank ! Thanks for your PR. |
…sPackage * Add methods to handle low memory events in MainApplication * Emit device events for low memory and trim memory notifications * Introduce switchToLowMemoryMode in StatusPackage to manage backend requests
* Implement logging of the last five historical process exit reasons on devices running Android R and above. * Handle cases where no exit reasons are found and log relevant details for each exit reason, including process name, reason, timestamp, and memory usage.
qfrank
force-pushed
the
frank/chore/low-memory
branch
from
3c94a83 to
b9ab48b
Compare
Done :) @mariia-skrypnyk |
88% of end-end tests have passedFailed tests (8)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletConnectSignTransactions:
Class TestWalletConnectLoggedOut:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletCollectibles:
Expected to fail tests (3)Click to expandClass TestWalletConnectSignTransactions:
Class TestCommunityMultipleDeviceMergedThree:
Class TestCommunityMultipleDeviceMerged:
Passed tests (77)Click to expandClass TestWalletOneDeviceTwo:
Class TestWalletOneDeviceThree:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestWalletConnectSignTransactions:
Class TestFallbackMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestAndroid12:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletCustomParamOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestAndroid13:
Class TestProfileOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletConnectDifferentNetworks:
Class TestWalletConnectBaseChecks:
Class TestCommunityMultipleDeviceMergedThree:
Class TestDeepLinksOneDevice:
Class TestProfileMultipleDevices:
Class TestWalletCollectibles:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this PR might help fixing issue #22463
when switch Status App in background,
onLowMemory/onTrimMemorymight be invoked, we get a chance to release some memory back to OS and keep our App stay alive longer rather than being killed.this PR also added getHistoricalProcessExitReasons
relate status-go PR
logcat log that shows
getHistoricalProcessExitReasonsworks:Testing notes
see if PR build would keep our App stay alive longer in the background, if you can make Android system to trigger
onLowMemory or onTrimMemorywithout usingamthat would be great! I haven't be able to reproduce ): However, when Status is in the background, you can runadb shell am send-trim-memory 22304 COMPLETEto triggeronLowMemory/onTrimMemorymanually. 22304 should be replaced with actual pid of Status.Platforms
Steps to test
status: ready.