Skip to content

chore: address commit comments for commit 75a786a (issue #7452) #7679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

anmolsah
Copy link
Contributor

Resolves #7452

Description

What is the purpose of this pull request?

This pull request:

  • Updates the description in the README.md file for the lognormal/pdf function to address the reviewer comment on commit 75a786a.

  • Specifically, it replaces the sentence:

    Evaluates the [probability density function][pdf] (PDF) for a [lognormal][lognormal-distribution] distribution with parameters mu (location parameter) and sigma (scale parameter).

    with the suggested wording:

    Evaluates the [probability density function][pdf] (PDF) of a [lognormal][lognormal-distribution] distribution with location parameter mu and scale parameter sigma.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Jul 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jul 16, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/lognormal/pdf $\color{green}325/325$
$\color{green}+100.00\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}325/325$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested change was for Line 170, not Line 59.

@anmolsah
Copy link
Contributor Author

Updated line 170 as per review. Let me know if anything else is needed.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @anmolsah!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 17, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 17, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: address commit comments for commit 75a786a (issue #7452)

PR-URL: https://github.com/stdlib-js/stdlib/pull/7679
Closes: https://github.com/stdlib-js/stdlib/issues/7452

Co-authored-by: Anmol Sah <kumarxxx242424@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 21b2d73 into stdlib-js:develop Jul 17, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 75a786a)
3 participants