Skip to content

Conversation

@manit2004
Copy link
Contributor

Resolves #9216

Description

What is the purpose of this pull request?

This pull request:

  • This PR fixes an outdated FIXME comment and implements the missing log10 operation in the createBenchmark1 function.

Changes

  • Implemented y = x.map( base ) to apply the log10 function to the ndarray
  • Removed the outdated FIXME comment claiming @stdlib/math/special/log10 doesn't exist
  • The log10 function was already imported at line 39 as base but wasn't being used

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 18, 2025
@socket-security
Copy link

socket-security bot commented Dec 18, 2025

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@manit2004
Copy link
Contributor Author

Note on Security Alerts

This PR does not introduce or modify any dependencies. The Socket security alerts for form-data and minimist are pre-existing vulnerabilities in the codebase that should be addressed in a separate dependency update PR.

@SocketSecurity ignore-all

@kgryte
Copy link
Member

kgryte commented Dec 18, 2025

As the referenced issue (ref: #9216) has been closed, I'll go ahead and close this PR, as we cannot resolve the FIXME at this time.

@kgryte kgryte closed this Dec 18, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated FIXME comment in log10 matrix benchmark

3 participants