Skip to content

Document how to customize SplitPhoneNumberField fields #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2025
Merged

Document how to customize SplitPhoneNumberField fields #631

merged 5 commits into from
Apr 10, 2025

Conversation

francoisfreitag
Copy link
Collaborator

@francoisfreitag francoisfreitag commented Mar 21, 2025 •
edited
Loading

Closes #624

@francoisfreitag francoisfreitag mentioned this pull request Mar 21, 2025
Closed
ilkkao
ilkkao approved these changes Mar 21, 2025
View reviewed changes
Copy link

@ilkkao ilkkao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Maybe makes sense to give practical example in docs like:

    def prefix_field(self):
        prefix_field = super().prefix_field()
        prefix_field.widget.attrs.update({'class': 'form-control', 'style': 'width: 300px;'})
        return prefix_field

@francoisfreitag
Import django.forms globally in docs
5c38ae6 
Avoid repeating from django import forms in all example, and
django.forms should be clear enough to understand where the import is
coming from.
@francoisfreitag
docs: Split example for SplitPhoneNumerField
275d445 
Another example is coming, and it becomes hard to identify what examples
are provided.
@francoisfreitag
docs: Customize SplitPhoneNumberField widgets attrs
10eea1f
@francoisfreitag francoisfreitag merged commit 65bc14f into stefanfoulis:main Apr 10, 2025
18 checks passed
@francoisfreitag francoisfreitag deleted the doc-split-override branch April 10, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ilkkao ilkkao ilkkao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set bootstrap class in a form field SplitPhoneNumberField()
2 participants
@francoisfreitag @ilkkao