-
Notifications
You must be signed in to change notification settings - Fork 10
feat(subscription): add triggerReason in notifications
#1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
triggerReason in notifications
Test Results 74 files ±0 74 suites ±0 1m 26s ⏱️ ±0s Results for commit aca9544. ± Comparison against base commit c1d55b6. This pull request removes 186 and adds 33 tests. Note that renamed tests count towards both. |
|
thomasBousselin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still prefer to have an update from the specification on this.
| ): Triple<Subscription, Notification, Boolean> = | ||
| notificationService.callSubscriber( | ||
| subscription, | ||
| // recurring subscriptions do not really apply to notification triggers, take the 1st as a default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It do not apply at all(since timeInterval and watchedAttributes are mutually exclusive).
So it is strange to send a random reason.
Maybe add a new NotificationTrigger reason for periodic Subscriptions.



No description provided.