Add &nomutepreview option and apply &volume to previews
#1198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When streaming video, it was already possible to monitor input audio by showing video controls for the local video preview and pressing the unmute button. This PR adds two features to enhance this functionality:
Add an option,
&nomutepreview, to automatically unmute the preview.If passed in sender mode, the preview still starts muted on the device selection screen, but gets unmuted when you press "start". This is to avoid undesired results if the wrong audio device is preselected.
The option can also be passed in director mode in order to monitor the director's own stream. In this case it takes effect as soon as the director enables their microphone/video, since there's no separate device selection screen.
Apply the
&volumesetting to local video previews (again, in both sender and director mode).By itself, this does not unmute the preview, but determines what volume you get if you press the unmute button. This can also be combined with
&nomutepreview.Documentation is included, but I wasn't able to test the formatting (I don't know how to replicate the Markdown-to-HTML process used for the docs site).
Features not included:
Monitoring a subset of input audio devices
Sending monitor output to a non-default audio device
Still, this is good enough for me. My use case involves setting an Elgato HDMI capture device as the video/audio input in order to stream gameplay (directly through vdo.ninja, no OBS). I need to monitor audio in order to hear the game.