Skip to content

Conversation

AlexCK-STFC
Copy link
Member

@AlexCK-STFC AlexCK-STFC commented Sep 23, 2025

This is a JSON-formatted list. It will usually include a contact email for the project. This can be selected for with MATCHES_REGEX i.e.

Edit: Added PROJECT_EMAIL, which is None if an email is not found

@AlexCK-STFC
Copy link
Member Author

@jose-caballero Enjoy

@jose-caballero
Copy link
Contributor

Hmm... We are not really interested in tags, are we?
At least for now, the only thing we care about is the email address. So, why not to add it as the new variable, instead of the whole tags content? You would need to do the regex in the library.
Now, what should the library do when there is no email address in tags?

  • return an empty string?
  • return None?
  • return a banana?
  • raise an exception?

@AlexCK-STFC
Copy link
Member Author

I'm broadly in favour of wrapping as much as I can with the query library, tags included.

Id rather too much is available than too little

Im happy to add Email as a separate property though, but I'd like to also keep tags even if it's sometimes blank

@AlexCK-STFC AlexCK-STFC changed the title ENH: Add "PROJECT_TAGS" property ENH: Add "PROJECT_TAGS" and "PROJECT_EMAIL" properties Sep 24, 2025
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.65%. Comparing base (23bd01e) to head (8dc3581).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         111      111           
  Lines        4051     4064   +13     
=======================================
+ Hits         4037     4050   +13     
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jose-caballero
jose-caballero previously approved these changes Sep 24, 2025
This is a JSON-formatted list. It will usually include a contact email for the project
@jose-caballero
Copy link
Contributor

Hmm. Will the method with double underscore work?

@AlexCK-STFC AlexCK-STFC merged commit 36978d2 into main Sep 24, 2025
11 checks passed
@AlexCK-STFC AlexCK-STFC deleted the add-project-tags branch September 24, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants