Skip to content

Conversation

gmatthews20
Copy link
Collaborator

@gmatthews20 gmatthews20 commented Sep 26, 2025

Description:

Sensor to raise jira issue when host aggregate metadata doesn't match between cloud environments

Special Notes:


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

@gmatthews20 gmatthews20 force-pushed the aggregate_diff branch 7 times, most recently from fb2ba7b to 36b4a13 Compare September 26, 2025 13:40
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 98.72611% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.92%. Comparing base (782c8e0) to head (a61df55).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/apis/utils/diff_utils.py 98.41% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #383      +/-   ##
===========================================
- Coverage   100.00%   99.92%   -0.08%     
===========================================
  Files          105      106       +1     
  Lines         2470     2606     +136     
  Branches       362      408      +46     
===========================================
+ Hits          2470     2604     +134     
- Partials         0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmatthews20 gmatthews20 force-pushed the aggregate_diff branch 2 times, most recently from 99e8554 to 65a6bda Compare September 26, 2025 13:53
Copy link
Collaborator

@anish-mudaraddi anish-mudaraddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider writing the functionality of deepdiff ourselves to limit our attack vectors.

Ad util function which runs a deepdiff on two objects and returns data compatible with tabulate tables
Increase poll interval to reduce noise

Fix testing
Get aggregates from two openstack instances, compares metadata on matching aggregates, outputs to a jira table

Add which cloud is source and target to logging
Add python 3.10 in preperation for stackstorm 3.9
Fix aggregate sensor tests
@AlexCK-STFC AlexCK-STFC force-pushed the aggregate_diff branch 5 times, most recently from a61df55 to f8a5d50 Compare October 3, 2025 10:24
@AlexCK-STFC
Copy link
Member

AlexCK-STFC commented Oct 3, 2025

Was gonna replace deepdiff directly in this branch but I'd rather in a different PR. Dropped my changes.

Copy link
Collaborator

@anish-mudaraddi anish-mudaraddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexCK-STFC is working on improvements which will land separately

@AlexCK-STFC AlexCK-STFC merged commit 51115c3 into main Oct 3, 2025
13 checks passed
@AlexCK-STFC AlexCK-STFC deleted the aggregate_diff branch October 3, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants