Skip to content

Conversation

AlexCK-STFC
Copy link
Member

@AlexCK-STFC AlexCK-STFC commented Oct 1, 2025

Description:

Note: Dates are hard-coded, while flavors are customisable.

This is because:

  • The dates are unlikely to change
  • It would be a pain to make them customisable from the format of the template

Also adds a helper "Print Email" debug function to the emailer

Special Notes:


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

@AlexCK-STFC AlexCK-STFC marked this pull request as draft October 1, 2025 15:31
@AlexCK-STFC
Copy link
Member Author

Draft until I add unit tests

Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c54c341) to head (67f330f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #389   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       106    +1     
  Lines         2468      2534   +66     
  Branches       356       371   +15     
=========================================
+ Hits          2468      2534   +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexCK-STFC AlexCK-STFC marked this pull request as ready for review October 2, 2025 08:35
@AlexCK-STFC AlexCK-STFC changed the title ENH: Add emailer for fixed line testing ENH: Add emailer for fixed line testing affected flavors Oct 2, 2025
@AlexCK-STFC AlexCK-STFC enabled auto-merge October 2, 2025 08:39
Copy link
Collaborator

@anish-mudaraddi anish-mudaraddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tempted to close this and reopen if we need it later

@AlexCK-STFC
Copy link
Member Author

Tempted to close this and reopen if we need it later

Shall we just merge to get the code in? The action won't run unless people run it.

I add the print_email func in this PR too, which would be nice-to-have for other actions

I can always split that off though

@anish-mudaraddi
Copy link
Collaborator

maybe set the action to enabled: false - so people won't use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants