Skip to content

Conversation

Logan-Harris24
Copy link

@Logan-Harris24 Logan-Harris24 commented Dec 9, 2024

As the title states, this PR:

  • Adds support for 2 new devices (Firefly V2 Pro & Charging Pad Chroma)
  • Fixes broken support for Basilisk V3 Pro (Wired & Wireless)
    • Support was added in librazermacos but accompanying device json was never added to razer-macos

Dependent on accompanying PR:

@Logan-Harris24
Copy link
Author

@stickoking Hi Prashant, not sure if you're still active on this repo but wanted to send a message to check. I have an interest in contributing to this project to keep things going. I had success in adding a few of my new devices and think I'll be able to work through the Issue requests here to support other devices if I'm able to.

I see there hasn't been much activity from you in ~9 months so if you see this, please just let me know and lets get some approvals flowing 😄

@stickoking
Copy link
Owner

@stickoking Hi Prashant, not sure if you're still active on this repo but wanted to send a message to check. I have an interest in contributing to this project to keep things going. I had success in adding a few of my new devices and think I'll be able to work through the Issue requests here to support other devices if I'm able to.

I see there hasn't been much activity from you in ~9 months so if you see this, please just let me know and lets get some approvals flowing 😄

I'm here I have just had some real life issues to deal with let me take a look and approve your request

stickoking
stickoking previously approved these changes Dec 14, 2024
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update your changes in the original repo make a PR there please?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my apologies I saw you made PR to the library I will review test make a build then update this for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants