Demacrofy I2C #219
Open
Demacrofy I2C #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because clippy warns about the I2C::i2c constructor, |
usbalbin
reviewed
Jul 22, 2025
|
Have you had the opportunity to test this? |
It can draw to a sh1106 display just fine, however I don't have any device that supports reads at hand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR to #218 , thought it was a good idea to split them
This one doesn't have any change to the driver other than moving stuff out of the macro.
Also, I think I2C is missing the DMA TargetAddress impl, I could put it in this PR if needed