Skip to content

fix: add missing onSuccess to DeleteRole.tsx#1248

Open
Asraye wants to merge 1 commit into
stoatchat:mainfrom
Asraye:fix/delete-role-success
Open

fix: add missing onSuccess to DeleteRole.tsx#1248
Asraye wants to merge 1 commit into
stoatchat:mainfrom
Asraye:fix/delete-role-success

Conversation

@Asraye

@Asraye Asraye commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

This PR adds the missing onSuccess to DeleteRole.tsx. Now successfully pushes the user back to the main roles window.

Fixes #1137

How was this PR tested?

Locally tested via making a role called "Test" and deleting it.

Screenshots & Screencasts (if appropriate)

Checklist:

  • I have carefully read the contributing guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR
  • I have confirmed that any new dependencies are strictly necessary
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code

Please declare, if any, LLM usage involved in creating this PR

None
...

This PR adds the missing onSuccess to DeleteRole.tsx. Now successfully pushes the user back to the main roles window. 

Signed-off-by: Asraye <asrayeofficial@gmail.com>
@Asraye Asraye requested review from a team as code owners June 2, 2026 15:32

@Dadadah Dadadah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. We'll get this merged after 0.8.0 releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleteing a role results in a broken UI

2 participants